A change for the worse on RHP?

Originally posted by yashin
[b]
lausey was correct I think

I found this in the code:

document.write('<a class="loggedInInfo" href="/core/gameserve.php">' + nGamesWaiting + ' game' + (nGamesWaiting>1?'s':''😉 + ' waiting</a><a href="#" onclick="XPopGamesUrgent( event );return false;">

I bet it used to be:

document.write('<a class="loggedInInfo" href="/core/gameser ...[text shortened]... interested in these bug-hunting thingies.[/b][/b]

For a non-programmer, it is very well deduced. You also noticed that it was done in the Javascript rather than the PHP (the PHP code will not be visible to the end user). I think your solution will work. Although this will be more efficient:

document.write('<a class="loggedInInfo" href="/core/gameserve.php">' + nGamesWaiting + ' game' + (nGamesWaiting<>1?'s':''😉 + ' waiting</a><a href="#" onclick="XPopGamesUrgent( event );return false;">

Although my Javascript is a little rusty. I am not sure if "not equals" is <> or !=.

What has amused me about this mistake is that someone sent feedback saying "are you EVER going to fix the 1 games waiting" error.

So, I replied saying that after nearly a decade, I probably should, and it was a low risk modification that could be hot fixed, so approx. 3 minutes later the solution was live - but as you discovered, broken in another (and really stupid) way.

If you hit ctrl+refresh in your browser to reload the javascript you will find the problem is fixed. (Or is it...? 😉 )

Originally posted by Russ
What has amused me about this mistake is that someone sent feedback saying "are you EVER going to fix the 1 games waiting" error.

So, I replied saying that after nearly a decade, I probably should, and it was a low risk modification that could be hot fixed, so approx. 3 minutes later the solution was live - but as you discovered, broken in another (and real ...[text shortened]... your browser to reload the javascript you will find the problem is fixed. (Or is it...? 😉 )

How much did it cost to buy the 's' back? ;-)